This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: address compiler warnings #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
previously approved these changes
Mar 7, 2025
vansangpfiev
reviewed
Mar 7, 2025
use macro PCLOSE to correctly map to _pclose on windows
The PCLOSE macro was mistakenly defined as pclose for Windows. This commit fixes the typo, reverting it back to _pclose
|
fixed it @qnixsynapse |
vansangpfiev
approved these changes
Mar 10, 2025
qnixsynapse
reviewed
Mar 10, 2025
qnixsynapse
approved these changes
Mar 10, 2025
|
can we push this as well @sangjanai |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
[[nodiscard]]attributes where return values were previously being ignored, ensuring proper error checking and resource management.Fixes Issues
Self Checklist