Unified Config Data: further comments and thoughts on unified Config data #143
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moroten
previously approved these changes
Sep 5, 2025
Trying out the "Approved" -> "Dismiss" workflow.
|
One outcome of this is that I want the dump subcommand to work in either an uninitialized repo, possibly because the configuration is broken - which was the original purpose of this subcommand - or an initialized repo where more information is available. My task at hand would benefit from easily constructing gerrit gitiles links for the commit, and I would then like to have the subproject commit shaid for a given supercommit. With that I could mechanically construct the gitiles link within the sub project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more elaboration on what we(I) should do later.
I do not work on this actively at the moment, but I can see gerrit code that also wants to read the projects from the
gittoprepo config (not source from .gitmodules) in the data flow.
We should also refactor the config to not be mutable, and split the refined data from the algorithm from the static data written to the toml.