feat: implement support for meshPlatforms #59
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive support for meshPlatforms in the MeshStack provider, adding both resource and data source capabilities for managing platform configurations. The implementation includes support for multiple cloud platforms (AWS, Azure, GCP, Kubernetes, OpenShift) with their specific configuration schemas and replication settings.
- Adds platform resource and data source with extensive schema definitions for all supported platform types
- Implements complete CRUD operations for platform management through the MeshStack API
- Provides example configurations for both resource and data source usage
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/provider.go | Registers the new platform resource and data source with the provider |
| internal/provider/platform_resource.go | Implements the platform resource with comprehensive schema and CRUD operations |
| internal/provider/platform_data_source.go | Implements the platform data source for reading existing platforms |
| examples/resources/meshstack_platform/resource.tf | Provides example configuration for platform resource usage |
| examples/data-sources/meshstack_platform/data-source.tf | Provides example configuration for platform data source usage |
| client/platform.go | Defines client structures and API methods for platform operations |
| client/client.go | Adds platform endpoint configuration to the client |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ee9e57f to
6045db1
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (4)
internal/provider/platform_data_source.go:1
- In the data source schema, the
gcp_rolefield is marked asRequired:on line 692, but then listed asRead-Only:on line 696. For data sources, all fields should be computed/read-only, not required. TheRequired:declaration appears to be incorrectly placed.
package provider
internal/provider/platform_data_source.go:1
- Similar issue as with GCP role mappings - the
openshift_rolefield is marked asRequired:on line 620, but then listed asRead-Only:on line 624. For data sources, fields should be computed/read-only, not required.
package provider
internal/provider/platform_data_source.go:1
- In the AWS SSO role mappings section, both
aws_roleandproject_role_refare marked as Required, but this is a data source where all fields should be read-only/computed.
package provider
internal/provider/platform_data_source.go:1
- The
namefield in project_role_ref is marked as Required in the data source documentation, but should be computed/read-only since this is a data source.
package provider
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6045db1 to
fdf1fd3
Compare
CU-86c55h4xp
fdf1fd3 to
ea462ab
Compare
CU-86c55h4xp
This PR only works after this PR from meshfed was merged: https://github.com/meshcloud/meshfed-release/pull/8589