Add validation/prevent --set-owner, --set-owner-short, and --set-ham …#782
Merged
ianmcorvidae merged 3 commits intomeshtastic:masterfrom Jun 23, 2025
Merged
Conversation
…from accepting empty or whitespace-only names. This is in relation to meshtastic#6867 firmware feature request meshtastic/firmware#6867
Merged
8 tasks
fifieldt
approved these changes
Jun 8, 2025
Closed
1 task
…ed _sendAdmin assertion
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 59.60% 60.08% +0.48%
==========================================
Files 24 24
Lines 4114 4149 +35
==========================================
+ Hits 2452 2493 +41
+ Misses 1662 1656 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Sorry for the delay on my getting back to this. Looks good, I'll merge it now, and probably push out a release soon as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…from accepting empty or whitespace-only names. This is in relation to feature request meshtastic/firmware#6867.
Added test validation and when trying to set long, short, and ham names we get the following via the cli:
Please let me know if there is anything else that I should add or modify. I have no idea what I am doing with Android SDK/development, so I believe someone will need to add this validation so the app also gives an error/warning when trying to set these.