fix(util): update waitForTraceRoute reset logic#785
Merged
ianmcorvidae merged 2 commits intomeshtastic:masterfrom Jun 9, 2025
grleblanc:master
Merged
fix(util): update waitForTraceRoute reset logic#785ianmcorvidae merged 2 commits intomeshtastic:masterfrom grleblanc:master
ianmcorvidae merged 2 commits intomeshtastic:masterfrom
grleblanc:master
Conversation
ianmcorvidae
reviewed
Jun 9, 2025
Contributor
ianmcorvidae
left a comment
There was a problem hiding this comment.
One small issue, otherwise LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 59.48% 59.50% +0.01%
==========================================
Files 24 24
Lines 4122 4121 -1
==========================================
Hits 2452 2452
+ Misses 1670 1669 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've also been running this change locally off Any plans to release this to the registry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #784