Fix --set-owner by calling setOwner!#813
Merged
ianmcorvidae merged 1 commit intomeshtastic:masterfrom Aug 18, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 60.13% 60.11% -0.02%
==========================================
Files 24 24
Lines 4219 4217 -2
==========================================
- Hits 2537 2535 -2
Misses 1682 1682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Sorry to take so long on this once again, looks good I think. Will merge it now. |
Member
Author
|
No worries! When you have a chance, I might recommend pushing a version patch since this is a very common command (that I broke, lol). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the call to setOwner out of the unmessageable conditional. It was accidentally indented in 58967e1