Fix Getting and Setting Excluded Modules: Ringtone and Canned Messages#818
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
- Coverage 60.11% 59.95% -0.16%
==========================================
Files 24 24
Lines 4217 4243 +26
==========================================
+ Hits 2535 2544 +9
- Misses 1682 1699 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can confirm that in my tests this does fix #814 for T1000E. |
|
Also works for T-Echo. It's a bit puzzling that availability is reported as True when there is no metadata or an exception flies but still better than blocking indefinitely :) |
|
Lost track of things, unfortunately as usual. I'll get this one in for now to get things back to working in some fashion, even though I think it can be improved (as you know too, of course). |
|
Oh, heh, this is already the improved fix vs. the last one I looked at, got it confused. Even better! Thanks for that. |
|
All good, I keep meaning to look at what other modules get excluded from firmware builds that we may wish to check for. I think these are main ones. Thanks for the merge and version bump! |
This PR adds checking the excluded_modules bitmask in our metadata before getting/setting Ringtone and Canned Messages.
Fixes #814