Splitting out true_defaults for moduleConfig in export_config()#858
Merged
ianmcorvidae merged 1 commit intomeshtastic:masterfrom Nov 12, 2025
Merged
Splitting out true_defaults for moduleConfig in export_config()#858ianmcorvidae merged 1 commit intomeshtastic:masterfrom
ianmcorvidae merged 1 commit intomeshtastic:masterfrom
Conversation
Contributor
|
Good catch! As long as CI doesn't complain this looks good to go to me. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 60.12% 60.13% +0.01%
==========================================
Files 24 24
Lines 4298 4300 +2
==========================================
+ Hits 2584 2586 +2
Misses 1714 1714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The output of export_config() normally omits config values that have been set to false, because most protobuf config settings default to false anyway and therefore don't normally need to be set to false. But because some config values may default to true, PR #807 adjusted things that so that where specified "true default" settings have been set false for the node, then those specified settings will still export as false when using export_config().
The Issue
This adjustment adds a second "true_defaults" variable and set_missing_flags_false() call in relation to ModuleConfig, and sticks the mqtt default there.