Add option to change the library naming scheme #15012
Conversation
There was a problem hiding this comment.
A thing to decide before merging is whether we should keep the current scheme (
.aon Windows) or switch to the platform default (.dllfor libs and.dll.libfor import libs).
This isn't the platform default at all, though? We're just making up our own new convention that nobody uses, aren't we? Isn't it .lib alone.
As far as I can tell this entire feature despite being cross platform basically exists solely to cater to windows users specifically. It should be a fatal error to set this property on Linux (or at least to change it from the default).
The purpose of setting it is really just to make users happy who insist that .a should mean mingw-gcc+ucrt while .lib should mean MSVC+ucrt. I'm not necessarily averse to making those users happy but it feels like a leaky abstraction if it affects other platforms too.
Making this change by default seems like it would break existing users who rely on the mingw linker search pattern support for detecting libraries by name rather than filepath (and which currently supports both lib*.a and *.lib, doesn't it?)
This just copies the way rustc does it. Which is the most reasonable way of making it work in a cross platform way. |
Actually no, for example on macOS you might want to use .so instead of .dylib sometimes. |
With this you can choose the library naming scheme regardless of the platform used.
A thing to decide before merging is whether we should keep the current scheme (
.aon Windows) or switch to the platform default (.dllfor libs and.dll.libfor import libs).