BUG: fix a problem with symlink support #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the existing `symlinks` test package so it exercises the bug. The situation without a `version` keyword in `meson.build` is more difficult because the dist tarball generated by Meson will be named `<project-name>-undefined.tar.gz`, which meson-python then changes to `<project-name-version.tar.gz`.
|
I'll leave the dist script for a follow-up and merge this, since @dnicolodi told me he is unavailable for a bit and I want to finish the 0.18.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the existing
symlinkstest package so it exercises the bug. The situation without aversionkeyword inmeson.buildis more difficult because the dist tarball generated by Meson will be named<project-name>-undefined.tar.gz, which meson-python then changes to<project-name-version.tar.gz.Note: I didn't include the dist script part discussed in #728 (comment), because I'm out of time right now. I think it should be done, but it's not blocking for 0.18.0 I think.