Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Initial implementation of dynamic test generation #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial implementation of dynamic test generation #68

wants to merge 1 commit into from

Conversation

paul-tqh-nguyen
Copy link
Contributor

@paul-tqh-nguyen paul-tqh-nguyen commented Jun 6, 2021 •
edited
Loading

This PR contains an initial implementation of dynamic test generation for our graphblas-opt tests.

It provides infrastructure for writing parameterized tests that generate *mlir test files at test-running time.

This is intended to address #66.

@coveralls
Copy link

coveralls commented Jun 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1113971746

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 79.757%
Files with Coverage Reduction New Missed Lines %
mlir_graphblas/src/build.py 1 91.89%
Totals Coverage Status
Change from base Build 1100003313: 0.06%
Covered Lines: 2037
Relevant Lines: 2554
💛 - Coveralls

@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 6 times, most recently from 1e8e7a9 to ace6195 Compare June 6, 2021 04:10
@paul-tqh-nguyen paul-tqh-nguyen requested a review from seibert June 6, 2021 04:27
@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 6 times, most recently from 20694d2 to fb0d3f8 Compare June 6, 2021 06:33
@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 16 times, most recently from 9c03905 to 7ff5cc9 Compare July 14, 2021 10:51
@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 6 times, most recently from d8418f1 to 85caf92 Compare July 14, 2021 11:04
@paul-tqh-nguyen
Copy link
Contributor Author

paul-tqh-nguyen commented Jul 14, 2021 •
edited
Loading

I've made several changes in the most recent commits to have the dynamically generated tests be run via pytest instead of at graphblas-opt compile time.

This commit also makes it so that pytest by default runs with -n auto so that the tests can be run in parallel.

I think this PR is ready for a second review.

I haven't yet moved all the tests over to use this new framework, but I'll do that after taking into account comments from the PR review.

@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 2 times, most recently from 084f9e3 to 4ae10ea Compare July 15, 2021 12:28
jim22k
jim22k reviewed Jul 22, 2021
View reviewed changes
paul-tqh-nguyen
paul-tqh-nguyen commented Jul 22, 2021
View reviewed changes
@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 7 times, most recently from ccff670 to 410b22a Compare August 9, 2021 17:49
@paul-tqh-nguyen paul-tqh-nguyen changed the title Initial implementation of dynamic test generation [WIP] Initial implementation of dynamic test generation Aug 9, 2021
@paul-tqh-nguyen paul-tqh-nguyen force-pushed the main branch 2 times, most recently from cf4915a to ab41d7d Compare August 9, 2021 18:31
@paul-tqh-nguyen paul-tqh-nguyen changed the title [WIP] Initial implementation of dynamic test generation Initial implementation of dynamic test generation Aug 9, 2021
@paul-tqh-nguyen paul-tqh-nguyen requested a review from jim22k August 9, 2021 18:41
@paul-tqh-nguyen
Initial implementation of dynamic test generation
1d2805d 
This commit contains the initial implementation of dynamic test generation for our graphblas-opt tests.

We now have a framework for writing parameterized tests that generate *mlir files at test-running time.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 910738596

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 80.212%
Files with Coverage Reduction New Missed Lines %
mlir_graphblas/mlir_builder.py 1 98.86%
mlir_graphblas/functions.py 7 89.69%
Totals Coverage Status
Change from base Build 910189001: -0.7%
Covered Lines: 1435
Relevant Lines: 1789
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 1113924730

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 80.031%
Files with Coverage Reduction New Missed Lines %
mlir_graphblas/src/build.py 1 91.89%
mlir_graphblas/functions.py 9 87.88%
Totals Coverage Status
Change from base Build 1100003313: 0.3%
Covered Lines: 2044
Relevant Lines: 2554
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seibert seibert Awaiting requested review from seibert

@jim22k jim22k Awaiting requested review from jim22k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-tqh-nguyen @coveralls @jim22k