Get default options from meteor settings #13005
Conversation
|
|
I have added the same option on the server side. Now you can pass parameters to AccountsServer from meteor.settings. I have also updated the documentation. On the other hand, I noticed that AccountsCommon "accounts_common.js" has a comment (line 211) with the option to initialize "accounts-base" with meteor.settings, but it is just that, a comment. There is no line of code in the file that uses meteor.settings to initialize "accounts-base". |
|
So far looking good. I just have one question that we need to test: does client setting propagate to server (possibly via commons)? If not then we need to make it happen and in this case server settings should override the client settings if there is conflict ( |
After reviewing the code I found that the server side only expects one param ("loginExpirationInDays") from the list in the "accounts" configuration, but this "loginExpirationInDays" param can only be used by the server side. It does not matter if there are duplicate parameters in the configuration. Also, the server does not use the options directly, it needs to call the config() method implicitly to change the loginExpirationInDays parameter. |
|
For the server documenting that only |
|
I like it, I think this is nice to have. 🚀 |
|
@gonzadelarge can you please update with the latest changes from 2.16. Thank you! |
Add support for custom configuration in AccountsClient initialization
Description
Currently, the accounts-base package begins before your own project does it. If you want to use a custom configuration, you must wait for the package to start and then pass the configuration you need. This can cause problems when, for example, you want to use a different DDP connection, such as login attempts to the wrong server on the first login attempt.
At this time, the accounts-base package is ready to receive different configuration parameters, however, you will have to wait for the package to start, and then, when your application starts, you can change the configuration.
To solve this problem, I modified the accounts-base client_main.js file to allow custom configuration when initializing AccountsClient. In my version, the AccountsClient constructor accepts the path to the meteor.settings file. If the Meteor.settings.public.packages.accounts field exists, the accounts will use the settings defined there. Otherwise, it will initialize with the default settings as it currently works.
Proposed Changes
Modification of the client_main.js file, line 10, to accept the path to the Meteor settings file and utilize it in the initialization of AccountsClient.
Related Issue
This change addresses the problem reported in issue #12870: Link to the issue
Additional Notes
This change has minimal impact on the existing accounts-base codebase and resolves a significant issue for users needing custom configurations.
** Example of use**
