[3.x] Fix checks #13086
Merged
[3.x] Fix checks #13086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS-384
Reproduction
Release 3.0 has still a pending check suddently failing.
Changing only
meteor-promisepackage triggers the GitHub action check. Other PRs fromrelease-3.0don't trigger this check. However, the check relies on fibers, expecting node version 14.x, not 20.x, as updated here. Yet, the node upgrade PR didn't trigger themeteor-promisecheck to confirm the node upgrade keeps the check green.Fix
Use node 14.x as part of meteor-promise check.