Fix issue with audit-argument-checks
after changes on env contexts
#13089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://forums.meteor.com/t/meteor-3-0-beta-7-is-out/61417/27
Issue
Following #13063, we encountered an issue where
audit-argument-checks
didn't validate correctly. This problem remained hidden until the inclusion of thematb33:collection-hooks
package, which brought it to light through the error message:Error: Did not check() all arguments during publisher
.The code snippet for reproduction is as follows:
Fix
Ensure proper validation of nullish values when preparing the context on
EnvironmentVariableAsync
code.audit-argument-checks
used the0
to hold its validation context.Pending
audit-argument-checks
similarly as the reproduction as it was not covered.