Fix Meteor npm subcommand among others [Meteor 3] #13377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5be602b.
…nning proper bat/cmd scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS-528
Context: #13260
Issue
In this PR we adapted major of the Node child spawn processes in Windows, which got a breaking change, requiring pass
shell: true. I remember some tests reacted on this, but it seems other places needed to be adapted, and failed silently. And this issue was one of them.Fix
Adding the missing
shell: trueseems to have solved the problem. Hopefully it doesn't break other flows as I experienced on the past on upgrading Node to the breaking change version and adapting some specific spawn child processes.I added a regression tests for us to be able to identify any regression on
meteor npm installcommand on Windows.