-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added meteor update --all-packages
to update indirect dependencies
#7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
182513f
to
5039296
Compare
See #7495. Still some decisions to be made: - Should we make --all-packages the default? - How should we deal with *new* indirect dependencies? - Should we do anything about underpinning indirect dependencies when updating?
5039296
to
01e1dbf
Compare
Was this intentionally not added to the command-line docs (help.txt)? I see it is not there, and that the checkbox in the PR description was left unchecked. |
That seems unlikely @glasser; I would probably suspect the PR got merged and I forgot about it :/ |
Cool, filed #8154. Also FWIW I ran it and it updated me with a bunch of
things and then said
```
Newer versions of the following indirect dependencies are available:
* coffeescript 1.11.1_4 (1.12.0_1 is available)
* percolate:synced-cron 1.3.0 (1.3.2 is available)
* percolatestudio:segment.io 2.0.0_1 (3.0.0 is available)
To update one or more of these packages, pass their names to
`meteor update`, or just run `meteor update --all-packages`.
```
which is funny because I already passed that flag.
|
That's pretty surprising @glasser. What happens if you run it again (w/ |
|
I guess the reporting of "newer versions available" is wrong here, in the sense that they are available but not installable with the current constraints. |
@glasser: Elaborating on what @tmeasday said, yes, it's an impossible constraint. Instead of
For the first two, you'll likely get a clear answer of which packages are holding the update back (due to their own dependencies on older versions). In that regard, I think the textual-suggestion to Instead of helpful information on the problem though, you also might run into an In the case of |
See #7495. Still some decisions to be made:
--all-packages
the default? (see conversation on the issue).The behavior now is to take the lowest version (with patches). It seems weird to do this to a new package that the user has no expectations about, TBH.
See the second half of this comment
Minutiae: