Allow both column name and index to be used when writing #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 93.95% 93.51% -0.45%
==========================================
Files 10 10
Lines 1258 1264 +6
Branches 184 184
==========================================
Hits 1182 1182
- Misses 46 52 +6
Partials 30 30
Continue to review full report at Codecov.
|
Owner
|
Can't you use named parameters for the attribute? [Column("Name", Index = 1)] |
Contributor
Author
|
When I try that I get the following compile error: "'Index' is not a valid named attribute argument. Named attribute arguments must be fields which are not readonly, static, or const, or read-write properties which are public and not static." |
Owner
|
True. I didn't realize the properties were read-only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an excel document we need to provide both the column index and the column name. Using 2 attributes doesn't work for writing, so I've added an additional constructor that does allow for that