Encapsulated ValueParserArgs #325
Conversation
ExcelMapper/ValueParserArgs.cs
Outdated
| /// <summary> | ||
| /// Encapsulation of arguments passed to a Value Parser function. | ||
| /// </summary> | ||
| public class ValueParserArgs |
There was a problem hiding this comment.
As I was only going one way (excel -> object) and didn't require saving back to excel, I named this ValueParserArgs, but I noticed that for writing back to excel the naming convention is ValueConverter. Maybe this class can get a more generic name that covers both cases
There was a problem hiding this comment.
I think ValueConverterArgs fits both cases. Perhaps we can change the method parameter names in Fetch to valueConverter, too?
There was a problem hiding this comment.
Updated the language in Fetch to valueConverter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 93.85% 93.91% +0.05%
==========================================
Files 11 12 +1
Lines 1433 1446 +13
Branches 213 213
==========================================
+ Hits 1345 1358 +13
Misses 60 60
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok, updated all references to valueParser to valueConverter |
Func args encapsulated in a new class, tests updated (but not thoroughly reviewed - let me know if there are specific test cases you'd like to see)