add Minkowski Distance #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgechev
requested changes
May 12, 2017
| it('should return 0 with points (0, 1, 4), (1, 1, 6) in order Negative Infinity.', function () { | ||
| expect(minkowskiDistance([0, 1, 4], [1, 1, 6], Number.NEGATIVE_INFINITY)).toBe(0); | ||
| }); | ||
| it('should return 8.372966759705923 with points (0, 3, 4, 5), (7, 6, 3, -1) in order 3.', function () { |
There was a problem hiding this comment.
Description doesn't match the content.
src/others/minkowski-distance.js
Outdated
| var i; | ||
|
|
||
| if (lx !== ly) { | ||
| throw '2 points must have same array length'; |
There was a problem hiding this comment.
Would you change it to "Both vectors should have same dimension"?
src/others/minkowski-distance.js
Outdated
| } | ||
|
|
||
| if (isNaN(p)) { | ||
| throw 'p must be a number'; |
There was a problem hiding this comment.
Would you change to it "The order "p" must be a number"?
src/others/minkowski-distance.js
Outdated
| } else if (p === Number.NEGATIVE_INFINITY) { | ||
| return chebyshevDistance(x, y, lx, p, Math.min); | ||
| } else if (p < 1) { | ||
| throw 'p less than 1 will violate triangle inequality'; |
There was a problem hiding this comment.
Would you change it to: "Order less than 1 will violate the triangle inequality"?
|
done with the requested changes. thanks for the review (Y) |
mgechev
approved these changes
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.