Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow comparator function to remove complex data from LinkedList. Als… #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Allow comparator function to remove complex data from LinkedList. Als… #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"no-empty": 2,
"no-plusplus": 2,
"no-undef": 2,
"linebreak-style": 2,
"linebreak-style": 0,
"max-depth": [
2,
4
Expand Down
5 changes: 3 additions & 2 deletions src/data-structures/linked-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,16 @@
* @param {Object} data Data which should be removed.
* @return {Boolean} Returns true if data has been removed.
*/
exports.LinkedList.prototype.remove = function (data) {
exports.LinkedList.prototype.remove = function (data, equals) {
if (this.first === null) {
return false;
}
var temp = this.first;
var next;
var prev;
while (temp) {
if (temp.data === data) {
var dataFound = equals ? equals(temp.data, data) : temp.data === data;
if (dataFound) {
next = temp.next;
prev = temp.prev;
if (next) {
Expand Down
34 changes: 34 additions & 0 deletions test/data-structures/linked-list.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,38 @@ describe('Linked List', function () {
}
linkedList.inorder(callback);
});
it('should delete data properly', function () {
var linkedList = new LinkedList();
linkedList.push(1);
linkedList.push(2);
linkedList.push(3);
linkedList.push(4);
linkedList.push(5);
linkedList.remove(3);
expect(linkedList.first.data).toBe(1);
expect(linkedList.first.next.data).toBe(2);
expect(linkedList.first.next.next.data).toBe(4);
expect(linkedList.first.next.next.next.data).toBe(5);
expect(linkedList.last.data).toBe(5);
});
it('should delete complex data properly', function () {
var linkedList = new LinkedList();
var item1 = {id: 1};
var item2 = {id: 2};
var item3 = {id: 3};
var item4 = {id: 4};
var item5 = {id: 5};
linkedList.push(item1);
linkedList.push(item2);
linkedList.push(item3);
linkedList.push(item4);
linkedList.push(item5);
var equals = function(a, b) { return a.id === b.id };
linkedList.remove({id: 3}, equals);
expect(linkedList.first.data).toBe(item1);
expect(linkedList.first.next.data).toBe(item2);
expect(linkedList.first.next.next.data).toBe(item4);
expect(linkedList.first.next.next.next.data).toBe(item5);
expect(linkedList.last.data).toBe(item5);
});
});