Support reading from BytesIO#125
Merged
Merged
Conversation
No longer necessary since Python 2 support has been dropped
It was only used in a few instances and it didn't save that many lines of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logic to correctly handle reading from BytesIO objects. Previously, parsing the data used
np.fromfilewhich does not support BytesIO objects. This is fixed by usingnp.frombufferandnp.fromstringto read in BytesIO objects.np.fromfiledoes not work withBytesIOobjects and therefore causedAdditionally, tests for reading/writing from BytesIO objects were enhanced.