Remove documentation regarding compression_level=0#91
Merged
addisonElliott merged 2 commits intoApr 2, 2019
Conversation
The GZIP library supports compression_level 0 for no compression but this is slower than using the encoding='raw' method. Thus, the documentation was removed for this case. Note that the user can still specify a compression_level of 0 at their own peril.
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 6 6
Lines 363 363
Branches 117 117
=======================================
Hits 360 360
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GZIP library supports a compression level of
0for no compression but this has been found to be slower than setting the encoding toraw. This PR removes documentation for settingcompression_level=0. In addition,bz2in Python does not support a compression level of 0. Another benefit of this PR is the unified compression level range.Note that the user can still specify a compression level of 0 at their own risk.
Fixes issue #88