Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use ResponseEvent instead of FilterResponseEvent #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2019
Merged

Use ResponseEvent instead of FilterResponseEvent #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EventListener/JsErrorToAlertListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;

class JsErrorToAlertListener implements EventSubscriberInterface
{

public function onKernelResponse(FilterResponseEvent $event): void
public function onKernelResponse(ResponseEvent $event): void
{
$response = $event->getResponse();
$request = $event->getRequest();
Expand Down
20 changes: 10 additions & 10 deletions tests/EventListener/JsErrorToAlertListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\StreamedResponse;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\KernelEvents;
Expand Down Expand Up @@ -52,7 +52,7 @@ public function testScriptIsInjected(string $responseBody, string $expectedRespo
{
$response = new Response($responseBody);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand Down Expand Up @@ -108,7 +108,7 @@ public function testScriptIsNotInjectedOnRedirection(int $statusCode): void
{
$response = new Response(self::BASIC_HTML, $statusCode);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand Down Expand Up @@ -139,7 +139,7 @@ public function testScriptIsNotInjectedToStreamedResponse(): void
{
$response = new StreamedResponse();

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -156,7 +156,7 @@ public function testScriptIsNotInjectedOnSubRequest(): void
{
$response = new Response(self::BASIC_HTML);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::SUB_REQUEST,
Expand All @@ -176,7 +176,7 @@ public function testScriptIsNotInjectedOnIncompleteHtmlResponses(): void
{
$response = new Response('<div>Some content</div>');

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -196,7 +196,7 @@ public function testScriptIsNotInjectedOnXmlHttpRequests(): void
{
$response = new Response(self::BASIC_HTML);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(true),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -216,7 +216,7 @@ public function testScriptIsNotInjectedOnNonHtmlRequests(): void
{
$response = new Response(self::BASIC_HTML);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(false, 'json'),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -237,7 +237,7 @@ public function testScriptIsNotInjectedOnContentDispositionAttachment(): void
$response = new Response(self::BASIC_HTML);
$response->headers->set('Content-Disposition', 'attachment; filename=test.html');

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -258,7 +258,7 @@ public function testScriptIsNotInjectedOnNonHtmlContentType(): void
$response = new Response(self::BASIC_HTML);
$response->headers->set('Content-Type', 'text/xml');

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand Down