add max size #489
Merged
add max size #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Summary
This PR introduces dynamic batch size limits for API requests by replacing hard-coded values with configurable settings from the environment manager.
- Added validation in
env.pyto ensuremax_client_batch_sizeis positive with default 2048 - Modified
pydantic_v2.pyto useMANAGER.max_client_batch_sizeforITEMS_LIMITmax length - Set
ITEMS_LIMIT_SMALLmax length to min(32,max_client_batch_size) for smaller batches - Increased
INPUT_STRINGmax length to 8192*15 characters to handle larger text inputs - Added assertion in
env.pyto validatequeue_sizeis positive
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 73.52% 73.58% +0.06%
==========================================
Files 41 41
Lines 3422 3430 +8
==========================================
+ Hits 2516 2524 +8
Misses 906 906 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.