Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wirthual
Copy link
Collaborator

Related Issue

closes #549

Additional Notes

Installed poetry 1.8.2

Steps to update:

poetry install -E all
poetry update colpali-engine

Then commited the updated lock file:
poetry show indicates colapli-engine version 0.38.0:

colpali-engine 0.3.8 The code used to train ...

Side effect colipali-engine requires these updated dependencies:
image

@wirthual wirthual requested review from Copilot and michaelfeil March 28, 2025 01:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request upgrades the colpali-engine dependency from version ^0.3.1 to 0.3.8 to address performance and vector representation discrepancies referenced in issue #549.

  • Updated colpali-engine version in the lock file (and indirectly in /libs/infinity_emb/pyproject.toml) to 0.3.8.
  • Adjusted installation steps to run "poetry update colpali-engine" with Poetry version 1.8.2.
  • Improved support for accurate and efficient vector representations as noted in issue #549.

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (1c84442) to head (d2ad93e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   79.85%   79.79%   -0.06%     
==========================================
  Files          43       43              
  Lines        3489     3489              
==========================================
- Hits         2786     2784       -2     
- Misses        703      705       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelfeil
Copy link
Owner

I’m not sure if this will actually work

@michaelfeil
Copy link
Owner

Lots of stuff in the change log

@wirthual
Copy link
Collaborator Author

I see. Do we need to increase test coverage to make sure it still works as intended?

@michaelfeil michaelfeil merged commit 88bad14 into main Mar 28, 2025
36 checks passed
@michaelfeil michaelfeil deleted the update-colpali-engine branch March 28, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to update Infinity to support newer colpali-engine version

4 participants