-
Notifications
You must be signed in to change notification settings - Fork 177
Update colpali engine to latest version #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The pull request upgrades the colpali-engine dependency from version ^0.3.1 to 0.3.8 to address performance and vector representation discrepancies referenced in issue #549.
- Updated colpali-engine version in the lock file (and indirectly in /libs/infinity_emb/pyproject.toml) to 0.3.8.
- Adjusted installation steps to run "poetry update colpali-engine" with Poetry version 1.8.2.
- Improved support for accurate and efficient vector representations as noted in issue #549.
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 79.85% 79.79% -0.06%
==========================================
Files 43 43
Lines 3489 3489
==========================================
- Hits 2786 2784 -2
- Misses 703 705 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I’m not sure if this will actually work |
|
Lots of stuff in the change log |
|
I see. Do we need to increase test coverage to make sure it still works as intended? |
Related Issue
closes #549
Additional Notes
Installed poetry 1.8.2
Steps to update:
Then commited the updated lock file:
poetry showindicates colapli-engine version 0.38.0:colpali-engine 0.3.8 The code used to train ...Side effect colipali-engine requires these updated dependencies:
