Add ColQwen2_5 to IMAGE_COL_MODELS #568
Conversation
There was a problem hiding this comment.
PR Summary
This PR adds 'ColQwen2_5' to the image collection models list in the vision module, but appears disconnected from its stated purpose of adding support for nomic-ai/nomic-embed-text-v1.5.
- PR changes in
/libs/infinity_emb/infinity_emb/transformer/vision/__init__.pydon't match issue #123's request for nomic-embed-text support - No documentation or tests provided for the new ColQwen2_5 model functionality
- Missing dependency specifications or version requirements for the new model
- Implementation appears incomplete as it only adds the model name without supporting infrastructure
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Thanks! |
|
I'm afraid it will need a merged model, as I don't have PEFT installed. https://huggingface.co/vidore/colqwen2.5-v0.2/discussions/5 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
- Coverage 79.85% 72.31% -7.54%
==========================================
Files 43 43
Lines 3489 3489
==========================================
- Hits 2786 2523 -263
- Misses 703 966 +263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@michaelfeil I'm using ColNomic which I merged myself, in case anyone else wants to use: |
|
@yasyf Pushing a custom image for you |
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.