Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements advanced filter syntax in the web UI to match the existing TUI filter functionality. The changes allow users to filter query events using duration comparisons (e.g., d>100ms), operation types (e.g., op:select), error flags, and text search patterns.
Changes:
- Updated filter input placeholder to show example filter syntax
- Implemented filter token parsing that matches the TUI filter.go implementation
- Added support for duration, operation, error, and text filter types with AND logic (all conditions must match)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/static/index.html | Updated filter input placeholder text to provide examples of the new filter syntax |
| web/static/app.js | Implemented filter parsing and matching logic that mirrors tui/filter.go, including parseFilterTokens, matchesFilter functions, and updated getFiltered and buildStats to use the new structured filter conditions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.