add Name to auth.Account as a user friendly alias #1992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-toogood
approved these changes
Sep 10, 2020
| @@ -54,13 +54,17 @@ func (j *jwtAuth) Generate(id string, opts ...auth.GenerateOption) (*auth.Accoun | |||
| if len(options.Issuer) == 0 { | |||
| options.Issuer = j.Options().Issuer | |||
| } | |||
|
|
|||
| name := options.Name | |||
| if name == "" { | |||
There was a problem hiding this comment.
Across the rest of the codebase, this is normally written as len(name) == 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Means that we can have ID as a UUID that never changes for the account and Name can be used as a user friendly alias which you could change. e.g. User would like to change their email or username.