Thanks to visit codestin.com
Credit goes to github.com

Skip to content

store: implement s3 blob store #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 15, 2020
Merged

store: implement s3 blob store #2005

merged 5 commits into from
Sep 15, 2020

Conversation

ben-toogood
Copy link
Contributor

domwong
domwong reviewed Sep 15, 2020
View reviewed changes
domwong
domwong reviewed Sep 15, 2020
View reviewed changes
domwong
domwong approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@domwong domwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Refreshingly simple using the minio stuff 👍

ben-toogood and others added 2 commits September 15, 2020 16:52
@ben-toogood @domwong
Update store/s3/s3.go
7a15afc 
Co-authored-by: Dominic Wong <[email protected]>
@ben-toogood @domwong
Update store/s3/s3.go
09d6d0e 
Co-authored-by: Dominic Wong <[email protected]>
@ben-toogood ben-toogood merged commit 35349bd into master Sep 15, 2020
@ben-toogood ben-toogood deleted the s3-blob-store branch September 15, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domwong domwong domwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-toogood @domwong