Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: optimize build-verify.yml workflow#1499

Merged
lbroudoux merged 3 commits intomicrocks:1.11.xfrom
inosmeet:ci
Mar 4, 2025
Merged

ci: optimize build-verify.yml workflow#1499
lbroudoux merged 3 commits intomicrocks:1.11.xfrom
inosmeet:ci

Conversation

@inosmeet
Copy link
Contributor

@inosmeet inosmeet commented Feb 12, 2025

Tests: https://github.com/inosmeet/microcks/actions/runs/13305709368/job/37156118925

This involves some redundant code while parallelizing integraiton tests and javadoc check.

Related issue(s)

Fixes: #1488
cc @lbroudoux @yada

@github-actions
Copy link

👋 @inosmeet

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

@inosmeet
Copy link
Contributor Author

I tried to move redundant up in a separate pre-requisite step using upload/download artifacts, but there seems to be some dependency issue:

Error:  Failed to execute goal on project microcks-app: Could not resolve dependencies for project io.github.microcks:microcks-app:jar:1.11.1-SNAPSHOT
Error:  dependency: io.github.microcks:microcks-util:jar:1.11.1-SNAPSHOT (compile)
Error:  	Could not find artifact io.github.microcks:microcks-util:jar:1.11.1-SNAPSHOT in central (https://repo.maven.apache.org/maven2)
Error:  dependency: io.github.microcks:microcks-model:jar:1.11.1-SNAPSHOT (compile)
Error:  	Could not find artifact io.github.microcks:microcks-model:jar:1.11.1-SNAPSHOT in central (https://repo.maven.apache.org/maven2)
Error:  dependency: io.github.microcks:microcks-el:jar:1.11.1-SNAPSHOT (compile)
Error:  	Could not find artifact io.github.microcks:microcks-el:jar:1.11.1-SNAPSHOT in central (https://repo.maven.apache.org/maven2)
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error: Process completed with exit code 1.

I would really appreciate some help here.

@inosmeet inosmeet changed the title Ci ci: optimize build-verify.yml workflow Feb 12, 2025
@lbroudoux
Copy link
Member

I tried to move redundant up in a separate pre-requisite step using upload/download artifacts, but there seems to be some dependency issue

I think that the local Maven repository where artifacts are installed needs to be shared between jobs in order to allow dependency resolution. So typically, to avoid doing mvn install in each job, we might have to transfer the workspace (where sources are cloned and locally compiled) + the local maven repository.

@inosmeet
Copy link
Contributor Author

@inosmeet
Copy link
Contributor Author

cc @lbroudoux

@lbroudoux lbroudoux changed the base branch from master to 1.11.x March 4, 2025 09:50
@lbroudoux
Copy link
Member

Hey @inosmeet

Thanks for putting all of this together: I took time to read and review it, and it seems good to me. I think it could bring some really nice improvements. However, I noticed that your initial PR was made from the master branch and not the current development one 1.11.x where I also put a lot of changes to optimize the Java native compilation....

Would you mind closing this one and re-proposing another PR that applies the same set of changes but starting from the 1.11.x branch? I think it would be way easier following this process.

Thanks!

inosmeet added 3 commits March 4, 2025 15:55
- Move container image build steps from `build-verify.yml` to
  `build-container.yml`
- Prevent container builds from running on PRs while allowing push and
  manual triggers

Signed-off-by: Meet Soni <[email protected]>
- Extract integration tests and javadoc checks into separate jobs
- Allow both to run in parallel, reducing CI execution time

Signed-off-by: Meet Soni <[email protected]>
@inosmeet
Copy link
Contributor Author

inosmeet commented Mar 4, 2025

Hey @lbroudoux

I've rebased the PR on 1.11.x, cherry-picked the commits. Does this work?

@inosmeet
Copy link
Contributor Author

inosmeet commented Mar 4, 2025

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this proposition! I expect some stuff to be broken but we'll see and fix them!

@lbroudoux lbroudoux added this to the 1.11.1 milestone Mar 4, 2025
@lbroudoux lbroudoux merged commit 8b6f43d into microcks:1.11.x Mar 4, 2025
3 of 4 checks passed
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

🎉 @inosmeet

You are now a Microcks community contributor! 💖

Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Kudos and please keep going, we need you 🙌

@inosmeet inosmeet deleted the ci branch April 6, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize CI/CD pipeline for contribution and Pull Request

2 participants