Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Allow to configure AI Copilot OpenAI endpoint when install via Helm#1548

Merged
lbroudoux merged 1 commit intomicrocks:1.11.xfrom
gopaljha29:add_api_url_open_ai
Mar 25, 2025
Merged

fix: Allow to configure AI Copilot OpenAI endpoint when install via Helm#1548
lbroudoux merged 1 commit intomicrocks:1.11.xfrom
gopaljha29:add_api_url_open_ai

Conversation

@gopaljha29
Copy link
Contributor

Description

  • api-url property can be passed as optional field for openai configuration

Related issue(s)

Fixes #1547

@github-actions
Copy link

👋 @gopaljha29

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

@lbroudoux lbroudoux changed the base branch from master to 1.11.x March 22, 2025 10:51
@lbroudoux
Copy link
Member

Thanks! Can you rebase your branch and start from 1.11.x? That's where development happens now.

@gopaljha29 gopaljha29 force-pushed the add_api_url_open_ai branch from 3735799 to ec34c05 Compare March 22, 2025 11:08
@gopaljha29
Copy link
Contributor Author

Thanks! Can you rebase your branch and start from 1.11.x? That's where development happens now.

I have rebased the PR on 1.11.x.

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@lbroudoux
Copy link
Member

This is very close to be merged! Can you please review and fix the DCO check violations? Commits have to signed.

This should be a matter of:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin add_api_url_open_ai

@gopaljha29 gopaljha29 force-pushed the add_api_url_open_ai branch from ec34c05 to ec4b9c8 Compare March 24, 2025 20:03
@gopaljha29
Copy link
Contributor Author

This is very close to be merged! Can you please review and fix the DCO check violations? Commits have to signed.

This should be a matter of:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin add_api_url_open_ai

I have signed the commit , now all checks are passing

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I looked at it again and realize the property name was wrong. Can you fix this?

api-url property can be passed as optional field for openai configuration

Signed-off-by: Gopal Jha<[email protected]>
Signed-off-by: Gopal Jha <[email protected]>
@gopaljha29 gopaljha29 force-pushed the add_api_url_open_ai branch from ec4b9c8 to 32422b8 Compare March 25, 2025 08:29
@gopaljha29 gopaljha29 requested a review from lbroudoux March 25, 2025 08:30
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lbroudoux lbroudoux merged commit 4093d38 into microcks:1.11.x Mar 25, 2025
10 of 11 checks passed
@github-actions
Copy link

🎉 @gopaljha29

You are now a Microcks community contributor! 💖

Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Kudos and please keep going, we need you 🙌

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to configure AI Copilot OpenAI endpoint when install via Helm

2 participants