feat: add installation script for [podman|docker]-compose#1552
feat: add installation script for [podman|docker]-compose#1552lbroudoux merged 3 commits intomicrocks:1.12.xfrom
Conversation
|
Hey, thanks for the proposals. Problems with bash scripts are that they also need to be tested and - if publicly delivered - written in an OS-independent manner (there are sometimes subtle differences between Linux and Darwin bash and zsh and ...). That's why we prefer to use and document the usage of standard As a consequence, I would prefer to keep the +1 for renaming the addons file for better consistency! We'll synchronize the documentation upgrade too. So to sum up, I think the next step is to decide the folder where to put the scripts, configurations and functional tests you're describing. I see two obvious options at the moment:
Personally, my preference goes to Any other suggestion is welcomed! |
|
With this, the script now handles installation for both docker as well as podman compose. Im not sure why there are merge-conflicts. I have already rebased my branch onto origin/1.11.x? My local working tree is also clean. cc @lbroudoux |
lbroudoux
left a comment
There was a problem hiding this comment.
Looks all good to me! Thanks,
|
Looks like the rebase to |
Signed-off-by: Meet Soni <[email protected]>
rename various compose and addon files for consistency. move installation script to `testsuite/`. Signed-off-by: Meet Soni <[email protected]>
Signed-off-by: Meet Soni <[email protected]>
lbroudoux
left a comment
There was a problem hiding this comment.
All the conflicts are now resolved. Go go go 🚀
Description
This script allows us to install microcks using docker-compose method along with it's several addons and modes.
--modeflag [default | devmode | proxy]--addonsflag.I've made some questionable changes here. Namely renaming the
docker-compose-async-addon.ymltoasync-addon.ymlto for consistency. This allows us to make the script smart, however by doing this, we do need to update many documentation instances, so this may not be appropriate.Lastly, if this one is approved then it can be incorporated to handle podman-compose installation as well. And again, file names will need to be updated.
As for the location of the script, it needs to be discussed further.
Part of #1480
cc @lbroudoux