fix: ui alignment for dropdown#1586
Merged
lbroudoux merged 2 commits intomicrocks:1.12.xfrom Apr 24, 2025
ChayanDass:fix/search-field-dropdown-alignment
Merged
fix: ui alignment for dropdown#1586lbroudoux merged 2 commits intomicrocks:1.12.xfrom ChayanDass:fix/search-field-dropdown-alignment
lbroudoux merged 2 commits intomicrocks:1.12.xfrom
ChayanDass:fix/search-field-dropdown-alignment
Conversation
Signed-off-by: chayandass <[email protected]>
lbroudoux
requested changes
Apr 24, 2025
Member
lbroudoux
left a comment
There was a problem hiding this comment.
Awesome! Thanks for taking the time to investigate this!
As the src/lib/patternfly-ng.css is an integrated vendor file, it would be better not to touch it. Is it possible to move this directive to src/style.css instead, in one "patternfly override" sections (lines 229-303)? I think it will be easier to maintain and to remind ourselves that we changed this.
Thanks a lot!
Signed-off-by: chayandass <[email protected]>
Contributor
Author
|
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the UI misalignment issue caused by the unnecessary addition of the
showclass when the dropdown is opened. Theshowclass was overriding the default styling (display: table-cell) applied to the.input-group-btncomponent, resulting in a broken layout with child elements appearing on multiple lines.Issue #1584