Refactor/Enchance Dialog Upload Component to have better UX#1674
Merged
lbroudoux merged 20 commits intomicrocks:1.13.xfrom Sep 2, 2025
Merged
Refactor/Enchance Dialog Upload Component to have better UX#1674lbroudoux merged 20 commits intomicrocks:1.13.xfrom
lbroudoux merged 20 commits intomicrocks:1.13.xfrom
Conversation
2199f41 to
b98e98b
Compare
Contributor
Author
|
linked to #1677 |
lbroudoux
reviewed
Aug 27, 2025
webapp/src/main/webapp/src/app/pages/importers/importers.page.ts
Outdated
Show resolved
Hide resolved
lbroudoux
reviewed
Aug 27, 2025
lbroudoux
reviewed
Aug 27, 2025
Member
lbroudoux
left a comment
There was a problem hiding this comment.
It looks really good. Thanks for this PR. I asked few questions along the review but we're close to a merge ;-)
b98e98b to
72d2e0c
Compare
43eeb69 to
aaeed63
Compare
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
- Move UploaderDialogComponent from importers page to shared components - Enhance uploader with per-file secondary artifact controls - Add support for multiple file uploads with individual settings - Implement scrollable file list UI with improved layout - Add clickable placeholder for file selection Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
- Create UploaderDialogService for consistent dialog handling - Support pre-selected files and custom configurations - Track modal state for drag-drop integration - Add methods to add files to existing open dialogs Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
- Add DragDropService for global file drag-drop detection - Create DragDropOverlayComponent for visual feedback during drag operations - Auto-navigate to services page when files are dropped - Integration with uploader dialog (add to existing vs open new) - Support HTML5 drag-drop API with proper event handling Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
- Add DragDropOverlayComponent to app template for global file drop feedback - Initialize DragDropService in AppComponent constructor - Implement proper cleanup in ngOnDestroy to remove event listeners - Import required components for drag-drop functionality Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
- Replace direct modal service usage with UploaderDialogService in ImportersPage - Add uploader dialog functionality to ServicesPage - Remove direct component imports in favor of service-based approach - Add refresh callbacks to update data after successful uploads Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
…acts first Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
b767e2f to
148683f
Compare
lbroudoux
approved these changes
Sep 2, 2025
Member
lbroudoux
left a comment
There was a problem hiding this comment.
Looks all good. Let shoot this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user wants to quickly import a specification into Microcks, he has to go though a lot of clicks and page changes.
For exemple when a user is on the homepage and wants to import a multi-part specification (ex: BeerCatalogApi), he has to:
Recording.2025-08-24.065514.mp4
This PR aims to ease this workflows by implementing multi-file upload as well as a drag and drop system
ezgif-6e430481f9a0ce.mp4
Related issue(s)