Feat/add instrumentation to scripts (Soap, Rest)#1753
Feat/add instrumentation to scripts (Soap, Rest)#1753lbroudoux merged 12 commits intomicrocks:1.13.xfrom
Conversation
lbroudoux
left a comment
There was a problem hiding this comment.
Thanks for the good work. These are mainly general comments and minor things that could be refactor later, but I'd like to get your point on those before merging. Thanks!
webapp/src/main/java/io/github/microcks/util/script/JsScriptEngineBinder.java
Show resolved
Hide resolved
webapp/src/main/java/io/github/microcks/util/script/JsScriptEngineBinder.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/io/github/microcks/util/script/ScriptEngineBinder.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/io/github/microcks/web/RestInvocationProcessor.java
Outdated
Show resolved
Hide resolved
|
@Apoorva64, don't forget to sign your commits! The DCO check is failing at the moment. |
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
34257ec to
aa85b26
Compare
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
… for scripts Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
lbroudoux
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks a lot @Apoorva64!
|
There's an issue in tests: It looks like there's no Maybe we should put the |
…vironments Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
Signed-off-by: Apoorva Srinivas Appadoo <[email protected]>
i've fixed the build by creating a resolver which resolves the Opentelemetry bean depending of where it is. When disabling the traces with otel.sdk.disabled it still works, it ignores the traces as expected |
It works, but it creates yet another bean. Wouldn't it be possible to just use |
lbroudoux
left a comment
There was a problem hiding this comment.
That's good. Thnaks. We will have to deep dive if we can finally get rid of the additional resolver.
Description
This PR adds instrumentation to JS and Groovy Script in Soap And Rest Flows.
The JS and Grovy scripts are not handled in the same way. The Groovy script engine throws when an error happens but the JS engine encapsulates the error, This is why the JS script instrumentation is added to the engine and the groovy script instrumentation is added to the Processor. I think we need a refactor to cleaunp this difference.
Related issue(s)
#1728