Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Review and fixed issued raised by sonarqube 1.13.x#1890

Open
pratik-mahalle wants to merge 2 commits intomicrocks:1.13.xfrom
pratik-mahalle:1.13.x
Open

Review and fixed issued raised by sonarqube 1.13.x#1890
pratik-mahalle wants to merge 2 commits intomicrocks:1.13.xfrom
pratik-mahalle:1.13.x

Conversation

@pratik-mahalle
Copy link

This PR addresses several code quality issues identified by SonarQube to improve code maintainability and test reliability.

Related

Fixes SonarQube code quality issues to improve maintainability and test reliability.

@pratik-mahalle pratik-mahalle marked this pull request as ready for review January 4, 2026 13:33
throw e;
}
@Testcontainers
class GooglePubSubProducerManagerIT {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum ... 🤔 It looks like you replaced the Managed implementation with its integration test. I think this is unintended. This should not even compile because the class name and file name do not match. Can you fix this?

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended replacement of implementation by its IT

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale State due to inactivity label Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/question stale State due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants