Draft
Conversation
Address low-risk Sonar issues:\n- remove unused imports\n- simplify single-expression lambda\n- replace lambda filters with method references\n- remove unused parameter/assignment in fuzz helper\n\nValidated with:\n- mvn -pl minions/async test -DskipITs\n- mvn -pl webapp -Dtest=MessageServiceTest test\n- mvn -pl webapp -DskipTests test-compile Signed-off-by: caesarsage <[email protected]>
Address Sonar issues in listener/task/controller paths:\n- avoid Optional#get without presence check\n- preserve interrupt status on InterruptedException\n- catch Exception instead of Throwable\n- replace generic throws Exception with specific checked exceptions\n- remove user-controlled value from webhook operationId error log path\n\nValidated with:\n- mvn -pl webapp -Dtest=ListenerCommonsTest test\n- mvn -pl webapp -DskipTests test-compile Signed-off-by: caesarsage <[email protected]>
Address Sonar issues around wildcard API types and serialization:\n- use List<Exchange> return types in MessageService event APIs\n- align TestController event endpoint return type\n- make ReplyInfo Serializable and document default constructor intent\n\nValidated with:\n- mvn -pl commons/model -DskipTests compile\n- mvn -pl webapp -Dtest=MessageServiceTest test Signed-off-by: caesarsage <[email protected]>
Signed-off-by: caesarsage <[email protected]>
Member
|
Ouch... that starts to represent a lot of changes in different unrelated part of the code base. Can you split in smaller and focused PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues in batch group by commits message
Validated with:
Related issue(s)
See #1883