Enable experimental alt text attribute, bump versions, add new debug mode for local coding #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ent, clean code with black, add debug mode
tantek
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
While this seems ok as an update, I would have preferred if the cleanup/codestyle aspects (different quotes, different lines for parentheses, different line breaks for conditional clauses, etc.) were done in a separate PR either before/after so it was easier to review functional changes separate from cosmetic/stylistic changes.
|
Seconding #5 (review) as I think just the bit re: upgrading to Python 3.9 will close #7. (Originally published at: https://jacky.wtf/2022/12/9DMy) |
|
LGTM. Agreed with @tantek that ideally style and functional changes should be separated in the future. Otherwise, ship it! |
kevinmarks
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three changes:
img_with_alt=Trueattribute to allow this website to send alt texts. More context on this feature is available in the mf2py Experimental features documentation.--debugoptional command line parameter to theapp.pyfile. This will aid contributors with local debugging.I deployed my PR onto a blank Heroku environment to make sure everything works, which you can test below:
https://mf2pyonline.herokuapp.com/