Use WavefrontSender interface in WavefrontMeterRegistry #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ront via HTTP transport-only (proxy is still supported as later versions of the Wavefront proxy accepts both metrics and histograms via HTTP on the socket port (typically 2878). This change is backwards compatible and will interpret existing proxy://<proxy_host>:2878 configurations as reporting via HTTP to http://<proxy_host>:2878 (note there is no SSL encryption) while leaving existing users that do use http reporting (e.g. https://longboard.wavefront.com) intact. This also changes the default reporting interval to match the Wavefront recommended default of once every minute.
|
Now we are good |
shakuzen
reviewed
Apr 1, 2020
...rometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontMeterRegistry.java
Show resolved
Hide resolved
...rometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontMeterRegistry.java
Show resolved
Hide resolved
shakuzen
reviewed
Apr 2, 2020
| } | ||
|
|
||
| static String getWavefrontReportingUri(WavefrontConfig wavefrontConfig) { | ||
| // proxy reporting is now http reporting on newer wavefront proxies. |
There was a problem hiding this comment.
Should we mention a minimum version of the proxy in release notes? Is there any concern some users may still be running an older version of the proxy?
There was a problem hiding this comment.
It would have to be a very old proxy, @basilisk487 care to comment?
There was a problem hiding this comment.
I believe HTTP support was added in 4.29, which was released in early July of 2018. Since we consider all 4.x and 5.x releases deprecated, it should have us covered.
shakuzen
approved these changes
Apr 2, 2020
shakuzen
added a commit
that referenced
this pull request
Apr 2, 2020
The `WavefrontSender` handles batching internally, so this removes partitioning we were doing on publishing meters. Renames private methods to reflect their modified behavior. Changes signature of `publishMetric` and `publishDistribution` to use the registry's `WavefrontSender`. Lowers log level of failed publish to WARN, which still may be too verbose on a per-metric/per-distribution basis to log publish failures. We can revisit this more in follow-ups. See #1901
|
I have added a polish commit for these changes in fac0211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use WavefrontSender interface to send metrics and histograms to Wavefront via HTTP transport-only (proxy is still supported as later versions of the Wavefront proxy accepts both metrics and histograms via HTTP on the socket port (typically 2878).
This change is backwards compatible and will interpret existing proxy://<proxy_host>:2878 configurations as reporting via HTTP to http://<proxy_host>:2878 (note there is no SSL encryption) while leaving existing users that do use http reporting (e.g. https://longboard.wavefront.com) intact.
This also changes the default reporting interval to match the Wavefront recommended default of once every minute.