Update default value logic for graphite tags #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
reviewed
Apr 19, 2020
...ations/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java
Outdated
Show resolved
Hide resolved
snicoll
added a commit
to spring-projects/spring-boot
that referenced
this pull request
Apr 20, 2020
This commit harmonizes how Graphite is configured. If tagsAsPrefix is set, it is used transparently. Otherwise, the new native tagging system is used. See micrometer-metrics/micrometer#2007 Closes gh-20884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Graphite tag support was initially added to micrometer in #1806, tag support was configured to be on by default.
In an ensuing discussion (micrometer-metrics/micrometer-docs#123), @snicoll suggested updating the logic to default to
trueunless the user has specified prefix tags.This PR implements those changes, as well as adding a configuration property for
graphiteTagsEnabled.Also related: spring-projects/spring-boot#20884