Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prepare for 1.4.7/1.5 relase #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pfalcon opened this issue Oct 18, 2015 · 40 comments
Closed

Prepare for 1.4.7/1.5 relase #1518

pfalcon opened this issue Oct 18, 2015 · 40 comments

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Oct 18, 2015

We've got few great features/fixes implemented lately, and overall 100+ commits and ~ a month past the last release, so it's probably time to think about new release. And I really think that recent features/fixes were great, to call it 1.5 release. However, unlike previous times, not all features as fully finished/merged yet, and more great features are in the queue, so the more important it's to make good release planning, to see what fits, and to not block merging of next features.

@dpgeorge
Copy link
Member

Yes, we can go to 1.5. Main features would be:

Anything else?

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 19, 2015

#1516 might wait for after release I'd think - just to not put too much goodies in changelog ;-). If you think it's important for it to be in, well...

So, regarding modussl, I'd like to add "make deplibs" to Travis - at least, better to also build upy with MICROPY_PY_USSL=1, but that will smash coverage numbers ;-). Still not enabled by default when cloned. But README has info how to build it.

@fojie
Copy link

fojie commented Oct 19, 2015

@dpgeorge does the banner line still say "Micro Python"? If so would this be a good time to update it to "MicroPython" according to decision(?) half a year ago?

@danicampora
Copy link
Member

I wanted to make #1485 in, now merged, but maybe @danicampora will want to refactor wipy impl.

Done in: ae70e98

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 19, 2015

@danicampora : Nice, thanks!

I'd like to add "make deplibs" to Travis

In #1521

@dpgeorge
Copy link
Member

better to also build upy with MICROPY_PY_USSL=1

Yes, we can do this. I'd suggest making micropython_coverage built with ussl, ie change the Makefile to make this happen.

but that will smash coverage numbers

We can deal with that later :)

@dpgeorge
Copy link
Member

does the banner line still say "Micro Python"

Nope, it now says "MicroPython" :)

Regarding REPL, and the second line of the banner that now says "Use CTRL-D to exit, CTRL-E for paste mode". I kind of don't like having CTRL in caps, it "yells" a bit too much for my liking, especially running uPy on the command line over and over. I'd prefer to change it to all lower case, ie "Use ctrl-D to exit, ctrl-E for paste mode". Am I being too picky?

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 19, 2015

ie "Use ctrl-D to exit, ctrl-E for paste mode". Am I being too picky?

I don't know if I'm too picky lately about all that lower case. Look at your keyboard - it's "Ctrl" ;-)

@dpgeorge
Copy link
Member

Look at your keyboard - it's "Ctrl" ;-)

On my keyboard it's not there because I have one of these https://en.wikipedia.org/wiki/Happy_Hacking_Keyboard with blank key tops :)

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 19, 2015

Ok, then let's approach it from that side that in English, names (and even titles) starts with capital letter, and that's name of keys, so it should be Ctrl-D (and arguably, it should be "+" to emphasize pressing at the same time)

@dpgeorge
Copy link
Member

and that's name of keys

Arguably it's not a key but rather a character, or command, being chr(4). And its name is "Control-D" (or EOF). It just so happens that you press the "Ctrl" key and the "D" key together to generate it.

https://en.wikipedia.org/wiki/Control-C

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 19, 2015

The message as printed there, isn't technical, but rather a mundane notice of which keyboard keys should be pressed together for this or that action.

@dpgeorge
Copy link
Member

My point was that they spell it "ctrl-D" etc (ie without plus).

@pramasoul
Copy link

^S

On Mon, Oct 19, 2015 at 4:18 PM, Damien George [email protected]
wrote:

My point was that they spell it "ctrl-D" etc (ie without plus).


Reply to this email directly or view it on GitHub
#1518 (comment)
.

@dhylands
Copy link
Contributor

Don't forget to fix pyboard.py to match the final decision.
On Oct 19, 2015 4:18 PM, "Tom Soulanille" [email protected] wrote:

^S

On Mon, Oct 19, 2015 at 4:18 PM, Damien George [email protected]
wrote:

My point was that they spell it "ctrl-D" etc (ie without plus).


Reply to this email directly or view it on GitHub
<
#1518 (comment)

.


Reply to this email directly or view it on GitHub
#1518 (comment)
.

@dpgeorge
Copy link
Member

Don't forget to fix pyboard.py to match the final decision.

No, I don't think we'll change the raw/friendly REPL printing in pyexec.c. Just the unix one. Otherwise it'll lead to difficulties with different versions of pyboard.py vs stmhal firmware.

@danicampora
Copy link
Member

I have two HP keyboards in front of me and both read ctrl ...

@dhylands
Copy link
Contributor

The 2 Mac keyboards (one for iPad, one for MacBook) both say 'control'

The 2 HP laptops I have say 'ctrl'

My Lenovo ThinkPad, System 76 laptop and all of my Dell laptops all say 'Ctrl'.

My Microsoft keyboard and all of my Dell keyboards say 'Ctrl'.

My Logitech keyboard says 'CTRL'

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 20, 2015

My point was that they spell it "ctrl-D" etc (ie without plus).

People who think about *ware being accessible for 11-years old use plus ;-) :

https://youtu.be/HAx9sJB1_eY?t=150

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 20, 2015

In the meantime, 8e6e9ea

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 20, 2015

So, #1522 is the last thing I have in my queue for release.

@dpgeorge
Copy link
Member

I just got esp8266 building again, and I'd also like to get all tests either properly skipping or passing on pyboard.

@dpgeorge
Copy link
Member

All tests now work (or skip) on pyboard. So I think I'm done.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 21, 2015

Nice, let's tag tomorrow and start merging new exciting stuff? ;-)

@dpgeorge , if you'll send announcement, I'd suggest spamming python-users and python-dev this time in addition to *-announce ;-). Or otherwise I'd plan to do that (when time permits).

@danicampora
Copy link
Member

I have 2 tests failing on WiPy, I couldn't take a look at it yesterday, but will do today.

@dpgeorge
Copy link
Member

I will prepare release 1.5.

@danicampora please let me know when the tests succeed.

@danicampora
Copy link
Member

I will, thanks!

@stinos
Copy link
Contributor

stinos commented Oct 21, 2015

Note that the msvc port currently doesn't compile due to lack of usleep. Not too hard to fix (though actual uSec resolution is not available afaik) but I don't think I will have time until next monday. If that is too long of a wait for you guys go ahead and release anyway, it's not like thousands are standing in line waiting for this port :P

@dpgeorge
Copy link
Member

Perhaps we should disable time.sleep_ms and time.sleep_us for _WIN32, just for now to get it building?

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 21, 2015

though actual uSec resolution is not available afaik

How is that possible?

If that is too long of a wait for you guys go ahead and release anyway, it's not like thousands are standing in line waiting for this port :P

Indeed, we don't (yet) have those formal release schedule, so releases as they are give various chance to polish their stuff, not require that. We'll have another release in a month (and for it, more issue than you know now will need to be tackled anyway).

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 21, 2015

I just got esp8266 building again

@dpgeorge : Btw, did you use latest esp-open-sdk (with vendor SDK 1.4.0)? I still didn't have that tested beyond compiling...

@dpgeorge
Copy link
Member

did you use latest esp-open-sdk

No, I'm using old 1.1.2.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 21, 2015

Any reason for that?

@dpgeorge
Copy link
Member

Any reason for that?

Simply lack of time.

@danicampora
Copy link
Member

I fixed my tests and pushed, go ahead when you are ready.

@dpgeorge
Copy link
Member

Ok, no pushing until 1.5!

@dpgeorge
Copy link
Member

Done.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 21, 2015

@dpgeorge: Thanks, and congrats! ;-)

@dpgeorge
Copy link
Member

@pfalcon I think congrats to us all, it's a team effort :) Even those who don't contribute direct code still contribute to the discussions, and submit great but reports, etc.

BTW, JNI was announced in 1.4.6 release, but we can still advertise it in announcements.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 21, 2015

I don't think 1.4.6 was anyhow widely announced, so if looking for "highlights", it can be mentioned.

tannewt added a commit to tannewt/circuitpython that referenced this issue Feb 12, 2019
This changes a number of things in displayio:
* Introduces BuiltinFont and Glyph so the built in font can be used by libraries. For boards with
  a font it is available as board.TERMINAL_FONT. Fixes micropython#1172
* Remove _load_row from Bitmap in favor of bitmap[] access. Index can be x/y tuple or overall index. Fixes micropython#1191
* Add width and height properties to Bitmap.
* Add insert and [] access to Group. Fixes micropython#1518
* Add index param to pop on Group.
* Terminal no longer takes unicode character info. It takes a BuiltinFont instead.
* Fix Terminal's handling of [###D vt100 commands used when up arrowing into repl history.
* Add x and y positions to Group plus scale as well.
* Add bitmap accessor for BuiltinFont
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants