renesas-ra: Consolidate hal_entry.c code and remove hal_entry() func. #11590
Conversation
|
@TakeoTakahashi2020 I am trying to simplify the renesas-ra port, to reduce the amount of code that is in the What do you think? |
|
Thank you very much @dpgeorge san. I agree with you and it's good for me. I just checked build and got REPL for all EKs & CLICKER. It looks working well. |
The hal_entry.c code is duplicated across all boards, so consolidate it to a common ra_hal.c file. And remove the hal_entry() function because it simply calls main(). Signed-off-by: Damien George <[email protected]>
3bd7e6b to
324d01e
Compare
|
Thank you @TakeoTakahashi2020 san for reviewing and testing. Now merged. |
|
@TakeoTakahashi2020 Is there any reason PA/B pins are not generated with |
|
Seem that numbering goes 9, A, B, so it's just hex, might be as easy as: diff --git a/ports/renesas-ra/boards/make-pins.py b/ports/renesas-ra/boards/make-pins.py
index 98d7026c2..baac4a69a 100644
--- a/ports/renesas-ra/boards/make-pins.py
+++ b/ports/renesas-ra/boards/make-pins.py
@@ -140,8 +140,8 @@ class Pins(object):
for row in rows:
try:
cpu_pin_name = row[0]
- cpu_pin_port = int(row[1])
- cpu_pin_bit = int(row[2])
+ cpu_pin_port = int(row[1], 16)
+ cpu_pin_bit = int(row[2], 16)
except:
continue
pin = Pin(cpu_pin_name, cpu_pin_port, cpu_pin_bit) |
|
@iabdalkader san, Thank you for the report of make-pins.py issue. I was not aware of it since EK & CLICKER's device has no PA/B pins. I will check it. |
The hal_entry.c code is duplicated across all boards, so consolidate it to a common ra_hal.c file. And remove the hal_entry() function because it simply calls main().