Update staccel.py #1167
Closed
Update staccel.py #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing parenthesis to class definition.
|
There is nothing wrong with the existing code. It's not a syntax error. |
|
Wow, your right, I'm so sorry! I should've done more looking and less
|
nickzoic
pushed a commit
to nickzoic/micropython
that referenced
this pull request
Oct 25, 2018
Support CPython standard library
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
May 12, 2025
Both micropython#1167 and micropython#5072 add traceback types. micropython#1167 added a bunch of named tuples in order to reproduce the traceback string. Since micropython#5072 added traceback printing, we don't need the old way. So, rollback PR micropython#1167 in favor of the newer traceback type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing parenthesis to class definition. Possible cause to this issue.
http://forum.micropython.org/viewtopic.php?f=2&t=595&p=3506#p3506
I'm not a programmer by trade so if this was done purposely, then disregard this change.