-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
renesas-ra: Consolidate all fsp_cfg header files to one location. #11846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renesas-ra: Consolidate all fsp_cfg header files to one location. #11846
Conversation
@TakeoTakahashi2020 @iabdalkader I'm trying to further simplify the board configuration for this port. What do you think about this change? |
I'm not sure if this will work, some modules may need different config options based on the project's configuration, @ TakeoTakahashi2020 would know more about this than I do. Ideally, I would like to see just one config file for the whole FSP SDK, per board, auto-generated by e2studio but that's not going to happen because FSP code #includes single config files. |
At the moment all these files are exactly the same, so at least we can start with this simplification for now.
We could possibly do that by:
Ultimately, I would like users to be able to define their own custom boards without using e2studio at all. Not sure how feasible that is, but IMO it's a good goal, and requires each board config to be as simple as possible. |
I think that's a better option than assuming that those config options are common defaults. Maybe a Python/bash script can take |
@dpgeorge san, Thank you for your proposal. It might be not easy but I also think so especially when the device is already supported by MicroPython. |
Most of the options here are just setting If in the future a board needs to customise these settings then we can add hooks to
Thank you @TakeoTakahashi2020 -san for testing. |
It's fine I have no strong opinions about this, however I think this PR should wait and the other PRs should be merged first, mainly because we have no control over how long it will take the other contributors to rebase their work, it could be days or weeks, and their PRs have been blocking our work, on the other hand rebasing this on their PRs should be trivial (the other PR adds one or two new boards). |
I understand. Although it is possible for me to update those PRs myself. |
ec637f8
to
5b2488a
Compare
The config header files with the same name have the same contents, so they don't need to be repeated for each board in the board's source directory. Signed-off-by: Damien George <[email protected]>
5b2488a
to
c2ea8b2
Compare
The config header files with the same name have the same contents, so they don't need to be repeated for each board in the board's sourc directory.