esp32/modules/inisetup.py: Allows to format the partition as FAT. #11864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Jun 25, 2023
ports/esp32/modules/inisetup.py
Outdated
| check_bootsec() | ||
| print("Performing initial setup") | ||
| os.VfsLfs2.mkfs(bdev) | ||
| vfs = os.VfsLfs2(bdev) | ||
| if Partition.info(bdev)[4] == "vfs": |
There was a problem hiding this comment.
You should be able to do just bdev.info()[4].
ports/esp32/modules/inisetup.py
Outdated
| if Partition.info(bdev)[4] == "vfs": | ||
| os.VfsLfs2.mkfs(bdev) | ||
| vfs = os.VfsLfs2(bdev) | ||
| elif Partition.info(bdev)[4] == "ffat": |
ports/esp32/modules/inisetup.py
Outdated
| @@ -35,10 +35,16 @@ def fs_corrupted(): | |||
|
|
|||
|
|
|||
| def setup(): | |||
| from esp32 import Partition | |||
There was a problem hiding this comment.
This import won't be needed with the changes below.
Signed-off-by: Wind-stormger <[email protected]>
|
Thanks for the fix! Now merged. |
Test passed on esp32-s3-box-lite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix this #11528 (comment) .
Now the compiled
micropython.uf2can be directly used in UF2 bootloader.