rp2/mphalport: Run TinyUSB stack while waiting for CDC input/output. #12926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM, sorry I missed this situation when testing the new TinyUSB code. (Adding a link back to #12846 for future reference.) |
Codecov Report
@@ Coverage Diff @@
## master #12926 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 158 158
Lines 20978 20978
=======================================
Hits 20649 20649
Misses 329 329 |
ddf737c to
8b25480
Compare
Signed-off-by: Damien George <[email protected]>
The recent change in bcbdee2 means that TinyUSB can no longer be run from within a soft (or hard) IRQ handler, ie when the scheduler is locked. That means that Python code that calls `print(...)` from within a scheduled function may block indefinitely if the USB CDC buffers are full. This commit fixes that problem by explicitly running the TinyUSB stack when waiting within stdio tx/rx functions. Signed-off-by: Damien George <[email protected]>
8b25480 to
a00c9d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change in bcbdee2 meant that TinyUSB can no longer be run from within a soft (or hard) IRQ handler, ie when the scheduler is locked. That means that Python code that calls
print(...)from within a scheduled function may block indefinitely if the USB CDC buffers are full.This commit fixes that problem by explicitly running the TinyUSB stack when waiting within stdio tx/rx functions.