tests,esp32: Skip soft timer test on esp32 port, rename. #15540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15540 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 161 161
Lines 21275 21281 +6
=======================================
+ Hits 20942 20948 +6
Misses 333 333 ☔ View full report in Codecov by Sentry. |
|
Seems like this PR accidentally got some I2S stuff committed as well? |
13515b9 to
824ae4b
Compare
Oops, thanks. Fixed. |
824ae4b to
b0c07af
Compare
|
See related #15284. In particular my comment #15284 (comment) The reason I never got around to fixing this test is because I kinda wanted it to be a reminder to fix this properly on esp32, ie allow it to create timers without an id. Because at the moment Ultimately I'd like to see:
In the meantime... maybe just let this test fail on esp32, or at least skip? |
b0c07af to
4a9a318
Compare
What about these two bits for now? That's what I've done here as they're the low hanging fruit. Skipping seems appropriate given the feature isn't implemented on that port for now. I would also like to see soft timers on esp32 port, in the long term. |
Yes, looks good now. |
Also rename the test to reflect that it's a soft timer test. Signed-off-by: Angus Gratton <[email protected]>
4a9a318 to
9ba04cc
Compare
Summary
Rename the extmod/machine_timer.py test to machine_soft_timer.py (as this is what it tests). Skip it on esp32, which has no soft timer support.
Found while testing #15523.
Testing
Allows this test to not fail on esp32.