esp32: Use configured stack-limit-margin when creating threads. #15583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives more stack margin for threads on ESP32C3. Signed-off-by: Damien George <[email protected]>
6 tasks
projectgus
reviewed
Aug 6, 2024
| @@ -161,7 +161,7 @@ mp_uint_t mp_thread_create_ex(void *(*entry)(void *), void *arg, size_t *stack_s | |||
| thread = th; | |||
|
|
|||
| // adjust the stack_size to provide room to recover from hitting the limit | |||
| *stack_size -= 1024; | |||
| *stack_size -= MP_TASK_STACK_LIMIT_MARGIN; | |||
There was a problem hiding this comment.
This code has a pre-existing race condition, because stack_size points to inside the thread 'arg' structure (and the thread is already created). If a context switch happens before here then it will set the limit to the full task stack size.
It still failed for me on IDF V5.2.2 until I moved the adjustment before creating the RTOS thread. However I think I found a simpler way to handle it, will submit PR after lunch.
(As an aside, I thought I saw the stress_recurse test failing intermittently on esp32 - maybe this is why.)
There was a problem hiding this comment.
Great find! I'll wait for your fix then.
There was a problem hiding this comment.
(Alternative now at #15605 )
|
Closing in favour of #15605. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This gives more stack margin for threads on ESP32C3 (it should have been done this way from the beginning). That's important for IDF v5.2, see #15523 (comment)
Testing
Ran the main test suite on an ESP32C3 using IDF v5.0.5. All tests pass (sans known failure
math_domain_special.py).