test,esp32: Fix machine_spi_rate test on ESP32-C3. #15659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15659 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 163 163
Lines 21293 21293
=======================================
Hits 20959 20959
Misses 334 334 ☔ View full report in Codecov by Sentry. |
|
Tested on an ESP32-C3-DevKitC-02:
|
Update to the test added in 1e98c4c, changes the SPI pins for ESP32-C3 (IO 18 and 19 are the native USB pins). Signed-off-by: Angus Gratton <[email protected]>
ccb754d to
fb4ae1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update to the test added in #15543, changes the SPI pins for ESP32-C3. Found while testing #15523, not sure if it's a regression there or if I missed it when testing the first time (IO 18 and 19 are the native USB pins).
Testing
Test passes on ESP32, ESP32-C3 and ESP32-S3.