-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
tools: Self-hosting of mpy-tool
.
#16042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5db2688
to
9f6405f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16042 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21864 21864
=======================================
Hits 21545 21545
Misses 319 319 ☔ View full report in Codecov by Sentry. |
Code size report:
|
a6b18f0
to
c27fa18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, definitely good to be able to self-host these basic tools.
Can you please split out the change to makeqstrdata.py
to a separate commit, because that's independently making makeqstrdata.py
MicroPython-compatible.
@vshymanskyy any comments on the above review? |
5b4fa03
to
0289e32
Compare
Can you please also split out the change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I don't have anything to add.
@vshymanskyy Do you have time to run through the minor outstanding discussions, or would you rather one of us picked them up?
@projectgus I believe @vshymanskyy said on Discord that he is rather preoccupied at the moment (the situation in Ukraine remains difficult). So I am sure he would appreciate it if anyone can do the small things to get this unblocked and merged :) |
822589d
to
efbd3f7
Compare
I've done an update according to the review. I'd not rebased, so changes can be viewed via https://github.com/micropython/micropython/compare/0289e32a9afdb87d82cde42996f5bf924a17517e..efbd3f7 However I see that there's a merge conflict, so I'll rebase now. |
efbd3f7
to
91e8a2f
Compare
Now rebased. Use the compare link above to see the pre-rebase changes. |
91e8a2f
to
e31b0a2
Compare
This looks good now, thanks @projectgus for updating. |
This allows running `py/makeqstrdata.py` with MicroPython itself. Signed-off-by: Volodymyr Shymanskyy <[email protected]> Signed-off-by: Angus Gratton <[email protected]>
This allows running mpy-tool using MicroPython itself. An appropriate test is added to CI to make sure it continues to work. Signed-off-by: Volodymyr Shymanskyy <[email protected]> Signed-off-by: Angus Gratton <[email protected]>
Signed-off-by: Volodymyr Shymanskyy <[email protected]> Signed-off-by: Angus Gratton <[email protected]>
e31b0a2
to
6fba1e4
Compare
Summary
This allows running
mpy-tool
using MicroPython itself.Testing
Currently it is used in
ViperIDE
to disassemble.mpy
files:.mpy
file is copied to the VM as wellmpy-tool
is used to dissect the.mpy
Also, a test is added to
ci.sh
Trade-offs and Alternatives
None that I'm aware of